diff options
| author | Sven Schnelle | 2019-01-28 17:53:33 +0100 |
|---|---|---|
| committer | Richard Henderson | 2019-02-06 11:49:21 +0100 |
| commit | 5c41496dd780fed67eadd64c59fc2cf21717ecf0 (patch) | |
| tree | eea97104e928aec3bbc10f61dc4d27dbb435f1ed | |
| parent | target/hppa: use tb_cflags() to access tb->cflags (diff) | |
| download | qemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.tar.gz qemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.tar.xz qemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.zip | |
target/hppa: fix setting registers via gdb
While doing 'set $pcoqh=0xf0000000' i triggered the assertion below.
The argument order for deposit64() is wrong, and val needs to be
moved to the end.
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20190128165333.3814-1-svens@stackframe.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | target/hppa/gdbstub.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c index e2e9c4d77f..3157a690f2 100644 --- a/target/hppa/gdbstub.c +++ b/target/hppa/gdbstub.c @@ -266,7 +266,7 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) case 65 ... 127: { uint64_t *fr = &env->fr[(n - 64) / 2]; - *fr = deposit64(*fr, val, (n & 1 ? 0 : 32), 32); + *fr = deposit64(*fr, (n & 1 ? 0 : 32), 32, val); } break; default: |