diff options
| author | Philippe Mathieu-Daudé | 2022-08-19 17:39:24 +0200 |
|---|---|---|
| committer | Peter Maydell | 2022-09-22 17:38:28 +0200 |
| commit | 5e689840a10e01dc2ab87defc5347337db8103da (patch) | |
| tree | 273bd76d85f080355a4ec30ed2c59b2b67bd9260 | |
| parent | chardev/baum: Avoid dynamic stack allocation (diff) | |
| download | qemu-5e689840a10e01dc2ab87defc5347337db8103da.tar.gz qemu-5e689840a10e01dc2ab87defc5347337db8103da.tar.xz qemu-5e689840a10e01dc2ab87defc5347337db8103da.zip | |
io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1
The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in
qio_channel_websock_handshake_send_res_ok() expands to a call
to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't
realize the string is const, so consider combined_key[] being
a variable-length array.
To remove the variable-length array, we provide it a hint to
the compiler by using sizeof() - 1 instead of strlen().
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-5-peter.maydell@linaro.org
| -rw-r--r-- | io/channel-websock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io/channel-websock.c b/io/channel-websock.c index 9619906ac3..fb4932ade7 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -32,7 +32,7 @@ #define QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN 24 #define QIO_CHANNEL_WEBSOCK_GUID "258EAFA5-E914-47DA-95CA-C5AB0DC85B11" -#define QIO_CHANNEL_WEBSOCK_GUID_LEN strlen(QIO_CHANNEL_WEBSOCK_GUID) +#define QIO_CHANNEL_WEBSOCK_GUID_LEN (sizeof(QIO_CHANNEL_WEBSOCK_GUID) - 1) #define QIO_CHANNEL_WEBSOCK_HEADER_PROTOCOL "sec-websocket-protocol" #define QIO_CHANNEL_WEBSOCK_HEADER_VERSION "sec-websocket-version" |