diff options
| author | Philippe Mathieu-Daudé | 2022-11-28 21:27:37 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2022-11-30 00:15:26 +0100 |
| commit | 61c34fc194b776ecadc39fb26b061331107e5599 (patch) | |
| tree | a31e02bc1e14a256434cddd43061a5ecee0ed645 | |
| parent | Merge tag 'seabios-1.16.1-20221128-pull-request' of https://gitlab.com/kraxel... (diff) | |
| download | qemu-61c34fc194b776ecadc39fb26b061331107e5599.tar.gz qemu-61c34fc194b776ecadc39fb26b061331107e5599.tar.xz qemu-61c34fc194b776ecadc39fb26b061331107e5599.zip | |
hw/display/qxl: Have qxl_log_command Return early if no log_cmd handler
Only 3 command types are logged: no need to call qxl_phys2virt()
for the other types. Using different cases will help to pass
different structure sizes to qxl_phys2virt() in a pair of commits.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20221128202741.4945-2-philmd@linaro.org>
| -rw-r--r-- | hw/display/qxl-logger.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index 68bfa47568..1bcf803db6 100644 --- a/hw/display/qxl-logger.c +++ b/hw/display/qxl-logger.c @@ -247,6 +247,16 @@ int qxl_log_command(PCIQXLDevice *qxl, const char *ring, QXLCommandExt *ext) qxl_name(qxl_type, ext->cmd.type), compat ? "(compat)" : ""); + switch (ext->cmd.type) { + case QXL_CMD_DRAW: + break; + case QXL_CMD_SURFACE: + break; + case QXL_CMD_CURSOR: + break; + default: + goto out; + } data = qxl_phys2virt(qxl, ext->cmd.data, ext->group_id); if (!data) { return 1; @@ -269,6 +279,7 @@ int qxl_log_command(PCIQXLDevice *qxl, const char *ring, QXLCommandExt *ext) qxl_log_cmd_cursor(qxl, data, ext->group_id); break; } +out: fprintf(stderr, "\n"); return 0; } |