diff options
| author | Corey Minyard | 2018-12-03 13:52:50 +0100 |
|---|---|---|
| committer | Peter Maydell | 2018-12-03 14:00:38 +0100 |
| commit | 629457a13080052c575779e1fd9f5eb5ee6b8ad9 (patch) | |
| tree | 2c5ce4c8317703bc421125e09b7acc7fe861b9bd | |
| parent | Update version for v3.1.0-rc3 release (diff) | |
| download | qemu-629457a13080052c575779e1fd9f5eb5ee6b8ad9.tar.gz qemu-629457a13080052c575779e1fd9f5eb5ee6b8ad9.tar.xz qemu-629457a13080052c575779e1fd9f5eb5ee6b8ad9.zip | |
i2c: Add a length check to the SMBus write handling
Avoid an overflow.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: QEMU Stable <qemu-stable@nongnu.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | hw/i2c/smbus.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c index 6ff77c582f..30028bfcc2 100644 --- a/hw/i2c/smbus.c +++ b/hw/i2c/smbus.c @@ -193,7 +193,11 @@ static int smbus_i2c_send(I2CSlave *s, uint8_t data) switch (dev->mode) { case SMBUS_WRITE_DATA: DPRINTF("Write data %02x\n", data); - dev->data_buf[dev->data_len++] = data; + if (dev->data_len >= sizeof(dev->data_buf)) { + BADF("Too many bytes sent\n"); + } else { + dev->data_buf[dev->data_len++] = data; + } break; default: BADF("Unexpected write in state %d\n", dev->mode); |