summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Tokarev2014-10-30 09:00:01 +0100
committerMichael Tokarev2014-11-02 08:04:34 +0100
commit6af76c6f7dbcc6255f5a5cac20ad61d1492d4052 (patch)
treebfa912780a87f47b5a8aeb5f2dc6f5679d78c23c
parentvirtio-9p-proxy: Fix sockfd leak (diff)
downloadqemu-6af76c6f7dbcc6255f5a5cac20ad61d1492d4052.tar.gz
qemu-6af76c6f7dbcc6255f5a5cac20ad61d1492d4052.tar.xz
qemu-6af76c6f7dbcc6255f5a5cac20ad61d1492d4052.zip
virtio-9p-proxy: fix error return in proxy_init()
proxy_init() does not check the return value of connect_namedsocket(), fix this by rearranging code a little bit. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
-rw-r--r--hw/9pfs/virtio-9p-proxy.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index e6bbb06319..2ec211bbea 100644
--- a/hw/9pfs/virtio-9p-proxy.c
+++ b/hw/9pfs/virtio-9p-proxy.c
@@ -1155,10 +1155,12 @@ static int proxy_init(FsContext *ctx)
sock_id = atoi(ctx->fs_root);
if (sock_id < 0) {
fprintf(stderr, "socket descriptor not initialized\n");
- g_free(proxy);
- return -1;
}
}
+ if (sock_id < 0) {
+ g_free(proxy);
+ return -1;
+ }
g_free(ctx->fs_root);
ctx->fs_root = NULL;