diff options
| author | Eduardo Habkost | 2017-05-03 22:35:51 +0200 |
|---|---|---|
| committer | Eduardo Habkost | 2017-05-17 15:37:01 +0200 |
| commit | 6c4672cae7bbae56c49dfa598e75dd02916c4bc5 (patch) | |
| tree | 932ae7baf12405128d56d9ac3bcd7d484ffe7928 | |
| parent | kvmclock: Remove user_creatable flag (diff) | |
| download | qemu-6c4672cae7bbae56c49dfa598e75dd02916c4bc5.tar.gz qemu-6c4672cae7bbae56c49dfa598e75dd02916c4bc5.tar.xz qemu-6c4672cae7bbae56c49dfa598e75dd02916c4bc5.zip | |
ioapic: Remove user_creatable flag
An ioapic device is already created by the q35 initialization
code, and using "-device ioapic" or "-device kvm-ioapic" will
always fail with "Only 1 ioapics allowed". Remove the
user_creatable flag from the ioapic device classes.
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-9-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| -rw-r--r-- | hw/i386/kvm/ioapic.c | 5 | ||||
| -rw-r--r-- | hw/intc/ioapic.c | 5 |
2 files changed, 0 insertions, 10 deletions
diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 348c405180..98ca480792 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -167,11 +167,6 @@ static void kvm_ioapic_class_init(ObjectClass *klass, void *data) k->post_load = kvm_ioapic_put; dc->reset = kvm_ioapic_reset; dc->props = kvm_ioapic_properties; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo kvm_ioapic_info = { diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index f9e4f77def..37c4386ae3 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -448,11 +448,6 @@ static void ioapic_class_init(ObjectClass *klass, void *data) k->post_load = ioapic_update_kvm_routes; dc->reset = ioapic_reset_common; dc->props = ioapic_properties; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo ioapic_info = { |