diff options
| author | Prasad J Pandit | 2020-10-21 08:05:50 +0200 |
|---|---|---|
| committer | Jason Wang | 2020-11-11 09:52:23 +0100 |
| commit | 7564bf7701f00214cdc8a678a9f7df765244def1 (patch) | |
| tree | 5a1822aa0753c3038b9a9585586515d96e28709b | |
| parent | net/colo-compare.c: Increase default queued packet scan frequency (diff) | |
| download | qemu-7564bf7701f00214cdc8a678a9f7df765244def1.tar.gz qemu-7564bf7701f00214cdc8a678a9f7df765244def1.tar.xz qemu-7564bf7701f00214cdc8a678a9f7df765244def1.zip | |
net: remove an assert call in eth_get_gso_type
eth_get_gso_type() routine returns segmentation offload type based on
L3 protocol type. It calls g_assert_not_reached if L3 protocol is
unknown, making the following return statement unreachable. Remove the
g_assert call, it maybe triggered by a guest user.
Reported-by: Gaoning Pan <pgn@zju.edu.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| -rw-r--r-- | net/eth.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -16,6 +16,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "net/eth.h" #include "net/checksum.h" #include "net/tap.h" @@ -71,9 +72,8 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto) return VIRTIO_NET_HDR_GSO_TCPV6 | ecn_state; } } - - /* Unsupported offload */ - g_assert_not_reached(); + qemu_log_mask(LOG_UNIMP, "%s: probably not GSO frame, " + "unknown L3 protocol: 0x%04"PRIx16"\n", __func__, l3_proto); return VIRTIO_NET_HDR_GSO_NONE | ecn_state; } |