summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefano Brivio2022-10-21 11:09:13 +0200
committerJason Wang2022-10-28 07:28:52 +0200
commit80d3e4779d6c5fee0402b0b48de15c3c812845a4 (patch)
treec4cb3cd0850eb09543a3d8207d4c6b7873023a00
parentnet: socket: Don't ignore EINVAL on netdev socket connection (diff)
downloadqemu-80d3e4779d6c5fee0402b0b48de15c3c812845a4.tar.gz
qemu-80d3e4779d6c5fee0402b0b48de15c3c812845a4.tar.xz
qemu-80d3e4779d6c5fee0402b0b48de15c3c812845a4.zip
net: stream: Don't ignore EINVAL on netdev socket connection
Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
-rw-r--r--net/stream.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/stream.c b/net/stream.c
index 0a7e84749a..e4388fe7e4 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");