diff options
| author | Vladimir Sementsov-Ogievskiy | 2019-10-17 16:21:22 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2019-10-25 15:15:01 +0200 |
| commit | 8ccf458af599673f622d14c8af84f063f69bba2d (patch) | |
| tree | 01945b195c1356d4bc824c545b878341a5fce0e9 | |
| parent | blockdev: Use error_report() in hmp_commit() (diff) | |
| download | qemu-8ccf458af599673f622d14c8af84f063f69bba2d.tar.gz qemu-8ccf458af599673f622d14c8af84f063f69bba2d.tar.xz qemu-8ccf458af599673f622d14c8af84f063f69bba2d.zip | |
block/backup: drop dead code from backup_job_create
After commit 00e30f05de1d195, there is no more "goto error" points
after job creation, so after "error:" @job is always NULL and we don't
need roll-back job creation.
Reported-by: Coverity (CID 1406402)
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/backup.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/block/backup.c b/block/backup.c index dddcf77f53..cf62b1a38c 100644 --- a/block/backup.c +++ b/block/backup.c @@ -474,10 +474,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, if (sync_bitmap) { bdrv_reclaim_dirty_bitmap(sync_bitmap, NULL); } - if (job) { - backup_clean(&job->common.job); - job_early_fail(&job->common.job); - } else if (backup_top) { + if (backup_top) { bdrv_backup_top_drop(backup_top); } |