diff options
| author | Isaku Yamahata | 2021-03-23 21:52:27 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2021-04-01 18:19:52 +0200 |
| commit | 8ddf54324858ce5e35272efa449f27fc0a19f957 (patch) | |
| tree | 23e64d7c64bf373614baabde35b47fb5b6c2be4a | |
| parent | isa/v582c686: Reinitialize ACPI PM device on reset (diff) | |
| download | qemu-8ddf54324858ce5e35272efa449f27fc0a19f957.tar.gz qemu-8ddf54324858ce5e35272efa449f27fc0a19f957.tar.xz qemu-8ddf54324858ce5e35272efa449f27fc0a19f957.zip | |
pci: sprinkle assert in PCI pin number
If a device model
(a) doesn't set the value to a correct interrupt number and then
(b) triggers an interrupt for itself,
it's device model bug. Add assert on interrupt pin number to catch
this kind of bug more obviously.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Message-Id: <9cf8ac3b17e162daac0971d7be32deb6a33ae6ec.1616532563.git.isaku.yamahata@intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | hw/pci/pci.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/pci/pci.c b/hw/pci/pci.c index ac9a24889c..8f35e13a0c 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1450,6 +1450,8 @@ static void pci_irq_handler(void *opaque, int irq_num, int level) PCIDevice *pci_dev = opaque; int change; + assert(0 <= irq_num && irq_num < PCI_NUM_PINS); + assert(level == 0 || level == 1); change = level - pci_irq_state(pci_dev, irq_num); if (!change) return; @@ -1469,6 +1471,7 @@ static inline int pci_intx(PCIDevice *pci_dev) qemu_irq pci_allocate_irq(PCIDevice *pci_dev) { int intx = pci_intx(pci_dev); + assert(0 <= intx && intx < PCI_NUM_PINS); return qemu_allocate_irq(pci_irq_handler, pci_dev, intx); } |