diff options
| author | Peng Liang | 2020-11-16 15:13:38 +0100 |
|---|---|---|
| committer | Gerd Hoffmann | 2020-12-11 08:06:40 +0100 |
| commit | 947191b4312a547621566d77d7b922d9e13bb63d (patch) | |
| tree | 50afcf6b5647fa58b00adeaba8e7bcd1b3fd596d | |
| parent | vnc: add alpha cursor support (diff) | |
| download | qemu-947191b4312a547621566d77d7b922d9e13bb63d.tar.gz qemu-947191b4312a547621566d77d7b922d9e13bb63d.tar.xz qemu-947191b4312a547621566d77d7b922d9e13bb63d.zip | |
ui/vnc: Add missing lock for send_color_map
vnc_write() should be locked after the RFB protocol is initialized.
Fixes: 0c426e4534b4 ("vnc: Add support for color map")
Cc: qemu-stable@nongnu.org
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
Message-id: 20201116141338.148911-1-liangpeng10@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | ui/vnc.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -2168,6 +2168,7 @@ static void send_color_map(VncState *vs) { int i; + vnc_lock_output(vs); vnc_write_u8(vs, VNC_MSG_SERVER_SET_COLOUR_MAP_ENTRIES); vnc_write_u8(vs, 0); /* padding */ vnc_write_u16(vs, 0); /* first color */ @@ -2180,6 +2181,7 @@ static void send_color_map(VncState *vs) vnc_write_u16(vs, (((i >> pf->gshift) & pf->gmax) << (16 - pf->gbits))); vnc_write_u16(vs, (((i >> pf->bshift) & pf->bmax) << (16 - pf->bbits))); } + vnc_unlock_output(vs); } static void set_pixel_format(VncState *vs, int bits_per_pixel, |