diff options
| author | Philippe Mathieu-Daudé | 2022-08-19 17:39:31 +0200 |
|---|---|---|
| committer | Peter Maydell | 2022-09-22 17:38:28 +0200 |
| commit | 972d325a8dc855aa3817d0df9e09fd556a0449f7 (patch) | |
| tree | bde61cffa182bc08a7f6e182db14cee9cb0507f5 | |
| parent | ui/curses: Avoid dynamic stack allocation (diff) | |
| download | qemu-972d325a8dc855aa3817d0df9e09fd556a0449f7.tar.gz qemu-972d325a8dc855aa3817d0df9e09fd556a0449f7.tar.xz qemu-972d325a8dc855aa3817d0df9e09fd556a0449f7.zip | |
tests/unit/test-vmstate: Avoid dynamic stack allocation
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-12-peter.maydell@linaro.org
| -rw-r--r-- | tests/unit/test-vmstate.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c index 72077b5780..541bb4f63e 100644 --- a/tests/unit/test-vmstate.c +++ b/tests/unit/test-vmstate.c @@ -87,17 +87,16 @@ static void save_buffer(const uint8_t *buf, size_t buf_size) static void compare_vmstate(const uint8_t *wire, size_t size) { QEMUFile *f = open_test_file(false); - uint8_t result[size]; + g_autofree uint8_t *result = g_malloc(size); /* read back as binary */ - g_assert_cmpint(qemu_get_buffer(f, result, sizeof(result)), ==, - sizeof(result)); + g_assert_cmpint(qemu_get_buffer(f, result, size), ==, size); g_assert(!qemu_file_get_error(f)); /* Compare that what is on the file is the same that what we expected to be there */ - SUCCESS(memcmp(result, wire, sizeof(result))); + SUCCESS(memcmp(result, wire, size)); /* Must reach EOF */ qemu_get_byte(f); |