summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDou Liyang2017-01-17 15:42:31 +0100
committerEduardo Habkost2017-01-24 00:25:36 +0100
commit9c6703fe82b29909cf2cf35b192892327841f71a (patch)
tree8c8083b0bc5e685f572824c1519899815d54d164
parenti386: Return migration-safe field on query-cpu-definitions (diff)
downloadqemu-9c6703fe82b29909cf2cf35b192892327841f71a.tar.gz
qemu-9c6703fe82b29909cf2cf35b192892327841f71a.tar.xz
qemu-9c6703fe82b29909cf2cf35b192892327841f71a.zip
vl: Ensure the numa_post_machine_init func in the appropriate location
In the numa_post_machine_init(), we use CPU_FOREACH macro to set all CPUs' namu_node. So, we should make sure that we call it after Qemu has already initialied all the CPUs. As we all know, the CPUs can be created by "-smp"(pc_new_cpu) or "-device"(qdev_device_add) command. But, before the device init, Qemu execute the numa_post_machine_init earlier. It makes the mapping of NUMA nodes and CPUs incorrect. The patch move the numa_post_machine_init func in the appropriate location. Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com> Message-Id: <1484664152-24446-2-git-send-email-douly.fnst@cn.fujitsu.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--vl.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/vl.c b/vl.c
index a260f30974..ed1cbe9c73 100644
--- a/vl.c
+++ b/vl.c
@@ -4513,8 +4513,6 @@ int main(int argc, char **argv, char **envp)
cpu_synchronize_all_post_init();
- numa_post_machine_init();
-
if (hax_enabled()) {
hax_sync_vcpus();
}
@@ -4539,6 +4537,9 @@ int main(int argc, char **argv, char **envp)
device_init_func, NULL, NULL)) {
exit(1);
}
+
+ numa_post_machine_init();
+
rom_reset_order_override();
/* Did we create any drives that we failed to create a device for? */