diff options
| author | Shannon Zhao | 2015-05-29 07:27:03 +0200 |
|---|---|---|
| committer | Michael Tokarev | 2015-06-03 13:21:24 +0200 |
| commit | 9ff7f5bddbe5814bafe5e798d2cf1087b58dc7b6 (patch) | |
| tree | 519732b313c27525cbcd4828632b35a83272ae0b | |
| parent | hw/arm/omap_sx1.c: Fix memory leak spotted by valgrind (diff) | |
| download | qemu-9ff7f5bddbe5814bafe5e798d2cf1087b58dc7b6.tar.gz qemu-9ff7f5bddbe5814bafe5e798d2cf1087b58dc7b6.tar.xz qemu-9ff7f5bddbe5814bafe5e798d2cf1087b58dc7b6.zip | |
hw/intc/exynos4210_gic.c: Fix memory leak by adjusting order
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | hw/intc/exynos4210_gic.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c index 0590d5dfb8..b2a4950bc3 100644 --- a/hw/intc/exynos4210_gic.c +++ b/hw/intc/exynos4210_gic.c @@ -213,9 +213,6 @@ void exynos4210_init_board_irqs(Exynos4210Irq *s) uint32_t grp, bit, irq_id, n; for (n = 0; n < EXYNOS4210_MAX_EXT_COMBINER_IN_IRQ; n++) { - s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], - s->ext_combiner_irq[n]); - irq_id = 0; if (n == EXYNOS4210_COMBINER_GET_IRQ_NUM(1, 4) || n == EXYNOS4210_COMBINER_GET_IRQ_NUM(12, 4)) { @@ -230,8 +227,10 @@ void exynos4210_init_board_irqs(Exynos4210Irq *s) if (irq_id) { s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], s->ext_gic_irq[irq_id-32]); + } else { + s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], + s->ext_combiner_irq[n]); } - } for (; n < EXYNOS4210_MAX_INT_COMBINER_IN_IRQ; n++) { /* these IDs are passed to Internal Combiner and External GIC */ |