diff options
| author | David Hildenbrand | 2019-09-03 15:09:47 +0200 |
|---|---|---|
| committer | David Hildenbrand | 2019-09-23 09:28:29 +0200 |
| commit | a3910396baaf2baa569e361e1a4fdcc487abf032 (patch) | |
| tree | 17d4b520a5a5a5f789f7b196d2ce91659dd6ae07 | |
| parent | s390x/tcg: MVPG: Check for specification exceptions (diff) | |
| download | qemu-a3910396baaf2baa569e361e1a4fdcc487abf032.tar.gz qemu-a3910396baaf2baa569e361e1a4fdcc487abf032.tar.xz qemu-a3910396baaf2baa569e361e1a4fdcc487abf032.zip | |
s390x/tcg: MVPG: Properly wrap the addresses
We have to mask of any unused bits. While at it, document what exactly is
missing.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
| -rw-r--r-- | target/s390x/mem_helper.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7dfa848744..746f647303 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -679,8 +679,15 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, uint64_t r1, uint64_t r2) s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, GETPC()); } - /* ??? missing r0 handling, which includes access keys, but more - importantly optional suppression of the exception! */ + r1 = wrap_address(env, r1 & TARGET_PAGE_MASK); + r2 = wrap_address(env, r2 & TARGET_PAGE_MASK); + + /* + * TODO: + * - Access key handling + * - CC-option with surpression of page-translation exceptions + * - Store r1/r2 register identifiers at real location 162 + */ fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, GETPC()); return 0; /* data moved */ } |