diff options
| author | Amit Shah | 2014-12-11 08:47:42 +0100 |
|---|---|---|
| committer | Amit Shah | 2015-01-05 09:32:47 +0100 |
| commit | a3a292c420d2fec3c07a7ca56fbb064cd57a298a (patch) | |
| tree | ab437da7616e45edd8918430594262cce794575e | |
| parent | Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20141223'... (diff) | |
| download | qemu-a3a292c420d2fec3c07a7ca56fbb064cd57a298a.tar.gz qemu-a3a292c420d2fec3c07a7ca56fbb064cd57a298a.tar.xz qemu-a3a292c420d2fec3c07a7ca56fbb064cd57a298a.zip | |
virtio-rng: fix check for period_ms validity
This was reported for this warning:
hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]
Reported-by: dcb
Suggested-by: dcb
Bug: https://bugs.launchpad.net/qemu/+bug/1393486
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
| -rw-r--r-- | hw/virtio/virtio-rng.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 473c04410e..06e71782b2 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -149,7 +149,7 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp) VirtIORNG *vrng = VIRTIO_RNG(dev); Error *local_err = NULL; - if (!vrng->conf.period_ms > 0) { + if (vrng->conf.period_ms <= 0) { error_setg(errp, "'period' parameter expects a positive integer"); return; } |