summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWarner Losh2022-06-12 16:16:46 +0200
committerWarner Losh2022-06-13 23:50:50 +0200
commitab5fd2d969855be6a0355e55d21b51c676f7b1b6 (patch)
treeab9c2b264bf7ba8e818823b52188fc36c69b0e3d
parentbsd-user: Implement chdir and fchdir (diff)
downloadqemu-ab5fd2d969855be6a0355e55d21b51c676f7b1b6.tar.gz
qemu-ab5fd2d969855be6a0355e55d21b51c676f7b1b6.tar.xz
qemu-ab5fd2d969855be6a0355e55d21b51c676f7b1b6.zip
bsd-user: Implement rename and renameat
Plus the helper LOCK_PATH2 and UNLOCK_PATH2 macros. Signed-off-by: Stacey Son <sson@FreeBSD.org> Signed-off-by: Jung-uk Kim <jkim@FreeBSD.org> Signed-off-by: Warner Losh <imp@bsdimp.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-rw-r--r--bsd-user/bsd-file.h45
-rw-r--r--bsd-user/freebsd/os-syscall.c8
2 files changed, 53 insertions, 0 deletions
diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h
index bc0a0c08d5..fd8aba9618 100644
--- a/bsd-user/bsd-file.h
+++ b/bsd-user/bsd-file.h
@@ -32,6 +32,24 @@ do { \
#define UNLOCK_PATH(p, arg) unlock_user(p, arg, 0)
+#define LOCK_PATH2(p1, arg1, p2, arg2) \
+do { \
+ (p1) = lock_user_string(arg1); \
+ if ((p1) == NULL) { \
+ return -TARGET_EFAULT; \
+ } \
+ (p2) = lock_user_string(arg2); \
+ if ((p2) == NULL) { \
+ unlock_user(p1, arg1, 0); \
+ return -TARGET_EFAULT; \
+ } \
+} while (0)
+
+#define UNLOCK_PATH2(p1, arg1, p2, arg2) \
+do { \
+ unlock_user(p2, arg2, 0); \
+ unlock_user(p1, arg1, 0); \
+} while (0)
extern struct iovec *lock_iovec(int type, abi_ulong target_addr, int count,
int copy);
@@ -330,4 +348,31 @@ static abi_long do_bsd_fchdir(abi_long arg1)
return get_errno(fchdir(arg1));
}
+/* rename(2) */
+static abi_long do_bsd_rename(abi_long arg1, abi_long arg2)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH2(p1, arg1, p2, arg2);
+ ret = get_errno(rename(p1, p2)); /* XXX path(p1), path(p2) */
+ UNLOCK_PATH2(p1, arg1, p2, arg2);
+
+ return ret;
+}
+
+/* renameat(2) */
+static abi_long do_bsd_renameat(abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4)
+{
+ abi_long ret;
+ void *p1, *p2;
+
+ LOCK_PATH2(p1, arg2, p2, arg4);
+ ret = get_errno(renameat(arg1, p1, arg3, p2));
+ UNLOCK_PATH2(p1, arg2, p2, arg4);
+
+ return ret;
+}
+
#endif /* BSD_FILE_H */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 8698db358c..2d62a54632 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -309,6 +309,14 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
ret = do_bsd_fchdir(arg1);
break;
+ case TARGET_FREEBSD_NR_rename: /* rename(2) */
+ ret = do_bsd_rename(arg1, arg2);
+ break;
+
+ case TARGET_FREEBSD_NR_renameat: /* renameat(2) */
+ ret = do_bsd_renameat(arg1, arg2, arg3, arg4);
+ break;
+
default:
qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
ret = -TARGET_ENOSYS;