diff options
| author | Markus Armbruster | 2015-12-17 17:35:21 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2016-01-13 15:16:16 +0100 |
| commit | acef5c02e54e6fb60f8f41a85772be47e5196e81 (patch) | |
| tree | d6a3799823ff83a45656284bcc2d8641da88040a | |
| parent | audio: Clean up inappropriate and unreachable use of hw_error() (diff) | |
| download | qemu-acef5c02e54e6fb60f8f41a85772be47e5196e81.tar.gz qemu-acef5c02e54e6fb60f8f41a85772be47e5196e81.tar.xz qemu-acef5c02e54e6fb60f8f41a85772be47e5196e81.zip | |
xen-hvm: Mark inappropriate error handling FIXME
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450370121-5768-14-git-send-email-armbru@redhat.com>
| -rw-r--r-- | xen-hvm.c | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms, void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) { + /* FIXME caller ram_block_add() wants error_setg() on failure */ unsigned long nr_pfn; xen_pfn_t *pfn_list; int i; @@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data) int xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) { + /* + * FIXME Returns -1 without cleaning up on some errors (harmless + * as long as the caller exit()s on error), dies with hw_error() + * on others. hw_error() isn't approprate here. Should probably + * simply exit() on all errors. + */ int i, rc; xen_pfn_t ioreq_pfn; xen_pfn_t bufioreq_pfn; |