diff options
| author | Fam Zheng | 2017-05-15 16:10:14 +0200 |
|---|---|---|
| committer | Max Reitz | 2017-05-29 15:39:54 +0200 |
| commit | adb998c12aa7aa22c78baaec5c1252721e89c3de (patch) | |
| tree | 0ec5571dcefb31316f191bfe3618c80c81827b1a | |
| parent | qemu-img: copy *key-secret opts when opening newly created files (diff) | |
| download | qemu-adb998c12aa7aa22c78baaec5c1252721e89c3de.tar.gz qemu-adb998c12aa7aa22c78baaec5c1252721e89c3de.tar.xz qemu-adb998c12aa7aa22c78baaec5c1252721e89c3de.zip | |
qemu-img: Fix leakage of options on error
Reported by Coverity.
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 20170515141014.25793-1-famz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
| -rw-r--r-- | qemu-img.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/qemu-img.c b/qemu-img.c index 0bf941ba56..5aef8ef047 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -295,6 +295,7 @@ static BlockBackend *img_open_opts(const char *optstr, if (qdict_haskey(options, BDRV_OPT_FORCE_SHARE) && !qdict_get_bool(options, BDRV_OPT_FORCE_SHARE)) { error_report("--force-share/-U conflicts with image options"); + QDECREF(options); return NULL; } qdict_put(options, BDRV_OPT_FORCE_SHARE, qbool_from_bool(true)); |