diff options
| author | Christian Svensson | 2019-09-04 09:05:04 +0200 |
|---|---|---|
| committer | Peter Maydell | 2019-09-13 17:05:01 +0200 |
| commit | ae275f71338ad4e567c7f2683bf28e66847eabe4 (patch) | |
| tree | cc93c8a95984aa0de034ffca5ee5e4d0d2add924 | |
| parent | aspeed/smc: Inject errors in DMA checksum (diff) | |
| download | qemu-ae275f71338ad4e567c7f2683bf28e66847eabe4.tar.gz qemu-ae275f71338ad4e567c7f2683bf28e66847eabe4.tar.xz qemu-ae275f71338ad4e567c7f2683bf28e66847eabe4.zip | |
aspeed/smc: Calculate checksum on normal DMA
This patch adds the missing checksum calculation on normal DMA transfer.
According to the datasheet this is how the SMC should behave.
Verified on AST1250 that the hardware matches the behaviour.
Signed-off-by: Christian Svensson <bluecmd@google.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-id: 20190904070506.1052-9-clg@kaod.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | hw/ssi/aspeed_smc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 5c3436db5e..9ffc7e0117 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -989,6 +989,7 @@ static void aspeed_smc_dma_rw(AspeedSMCState *s) s->regs[R_DMA_FLASH_ADDR] += 4; s->regs[R_DMA_DRAM_ADDR] += 4; s->regs[R_DMA_LEN] -= 4; + s->regs[R_DMA_CHECKSUM] += data; } } |