diff options
| author | Markus Armbruster | 2020-06-10 07:32:29 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2020-06-15 22:05:28 +0200 |
| commit | b0d09949fe2e0d3ebe806356bf782894f5b8acc5 (patch) | |
| tree | 1bbbf8e1019478261199c0739c30be833364b6ca | |
| parent | sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls (diff) | |
| download | qemu-b0d09949fe2e0d3ebe806356bf782894f5b8acc5.tar.gz qemu-b0d09949fe2e0d3ebe806356bf782894f5b8acc5.tar.xz qemu-b0d09949fe2e0d3ebe806356bf782894f5b8acc5.zip | |
microbit: Tidy up sysbus_init_child_obj() @child argument
The callers of sysbus_init_child_obj() commonly pass either &child,
sizeof(child), or pchild, sizeof(*pchild). Tidy up two that don't,
mostly to keep future commits simpler.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-41-armbru@redhat.com>
| -rw-r--r-- | hw/arm/microbit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c index ef213695bd..72fab429c4 100644 --- a/hw/arm/microbit.c +++ b/hw/arm/microbit.c @@ -39,7 +39,7 @@ static void microbit_init(MachineState *machine) Object *soc = OBJECT(&s->nrf51); Object *i2c = OBJECT(&s->i2c); - sysbus_init_child_obj(OBJECT(machine), "nrf51", soc, sizeof(s->nrf51), + sysbus_init_child_obj(OBJECT(machine), "nrf51", &s->nrf51, sizeof(s->nrf51), TYPE_NRF51_SOC); qdev_prop_set_chr(DEVICE(&s->nrf51), "serial0", serial_hd(0)); object_property_set_link(soc, OBJECT(system_memory), "memory", @@ -51,7 +51,7 @@ static void microbit_init(MachineState *machine) * hack until we implement the nRF51 TWI controller properly and the * magnetometer/accelerometer devices. */ - sysbus_init_child_obj(OBJECT(machine), "microbit.twi", i2c, + sysbus_init_child_obj(OBJECT(machine), "microbit.twi", &s->i2c, sizeof(s->i2c), TYPE_MICROBIT_I2C); object_property_set_bool(i2c, true, "realized", &error_fatal); mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(i2c), 0); |