diff options
| author | Changlong Xie | 2016-06-23 10:57:20 +0200 |
|---|---|---|
| committer | Jeff Cody | 2016-06-29 05:08:13 +0200 |
| commit | b48100cf07c94f66feef6886d3697eac8635bce4 (patch) | |
| tree | 13d54f6367e22bdf927cce40861d41713ad762d3 | |
| parent | iotests: add small-granularity mirror test (diff) | |
| download | qemu-b48100cf07c94f66feef6886d3697eac8635bce4.tar.gz qemu-b48100cf07c94f66feef6886d3697eac8635bce4.tar.xz qemu-b48100cf07c94f66feef6886d3697eac8635bce4.zip | |
blockjob: assert(cb) when create job
Callback for block job should always exist
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1466672241-22485-2-git-send-email-xiecl.fnst@cn.fujitsu.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
| -rw-r--r-- | block/backup.c | 1 | ||||
| -rw-r--r-- | blockjob.c | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/block/backup.c b/block/backup.c index 581269b29a..f87f8d539b 100644 --- a/block/backup.c +++ b/block/backup.c @@ -489,7 +489,6 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target, assert(bs); assert(target); - assert(cb); if (bs == target) { error_setg(errp, "Source and target cannot be the same"); diff --git a/blockjob.c b/blockjob.c index 90c4e262b0..205da9df4e 100644 --- a/blockjob.c +++ b/blockjob.c @@ -110,6 +110,7 @@ void *block_job_create(const BlockJobDriver *driver, BlockDriverState *bs, BlockBackend *blk; BlockJob *job; + assert(cb); if (bs->job) { error_setg(errp, QERR_DEVICE_IN_USE, bdrv_get_device_name(bs)); return NULL; |