diff options
| author | David Hildenbrand | 2019-09-03 13:38:12 +0200 |
|---|---|---|
| committer | David Hildenbrand | 2019-09-23 09:28:29 +0200 |
| commit | b7dd1f7fd4568326027e8fdf6dcca656e1ce95b9 (patch) | |
| tree | 9f9720a20f408beb8814bfc9ee52f9a62295ca4d | |
| parent | s390x/tcg: MVC: Increment the length once (diff) | |
| download | qemu-b7dd1f7fd4568326027e8fdf6dcca656e1ce95b9.tar.gz qemu-b7dd1f7fd4568326027e8fdf6dcca656e1ce95b9.tar.xz qemu-b7dd1f7fd4568326027e8fdf6dcca656e1ce95b9.zip | |
s390x/tcg: MVC: Use is_destructive_overlap()
Let's use the new helper, that also detects destructive overlaps when
wrapping.
We'll make the remaining code (e.g., fast_memmove()) aware of wrapping
later.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
| -rw-r--r-- | target/s390x/mem_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 013e8d6045..c31cf49593 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -330,7 +330,7 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t l, uint64_t dest, */ if (dest == src + 1) { fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra); - } else if (dest < src || src + l <= dest) { + } else if (!is_destructive_overlap(env, dest, src, l)) { fast_memmove(env, dest, src, l, ra); } else { for (i = 0; i < l; i++) { |