diff options
| author | David Gibson | 2017-07-13 02:52:39 +0200 |
|---|---|---|
| committer | David Gibson | 2017-07-17 07:07:05 +0200 |
| commit | ba50822ff835c197563423b688afc6d0fe50f7d0 (patch) | |
| tree | db49ff48c6290ae9bab6236a3741560f93b89af8 | |
| parent | spapr: Simplify unplug path (diff) | |
| download | qemu-ba50822ff835c197563423b688afc6d0fe50f7d0.tar.gz qemu-ba50822ff835c197563423b688afc6d0fe50f7d0.tar.xz qemu-ba50822ff835c197563423b688afc6d0fe50f7d0.zip | |
spapr: Abort on delete failure in spapr_drc_release()
We currently ignore errors from the object_property_del() in
spapr_drc_release(). But the only way that could fail is if the property
doesn't exist, in which case it's a bug that we're in spapr_drc_release()
at all. So change from ignoring to abort()ing on errors.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | hw/ppc/spapr_drc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 7f872a4803..fd5614094d 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -367,7 +367,7 @@ static void spapr_drc_release(sPAPRDRConnector *drc) g_free(drc->fdt); drc->fdt = NULL; drc->fdt_start_offset = 0; - object_property_del(OBJECT(drc), "device", NULL); + object_property_del(OBJECT(drc), "device", &error_abort); drc->dev = NULL; } |