diff options
| author | Philippe Mathieu-Daudé | 2020-08-21 21:53:49 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2020-09-07 12:23:55 +0200 |
| commit | bf6ce5ec6d6846d7c1fc3899438ec11efc9c8fc8 (patch) | |
| tree | e1ab80a2e0efb472ca70ea66fae692f98833e4fa | |
| parent | block/nvme: Define INDEX macros to ease code review (diff) | |
| download | qemu-bf6ce5ec6d6846d7c1fc3899438ec11efc9c8fc8.tar.gz qemu-bf6ce5ec6d6846d7c1fc3899438ec11efc9c8fc8.tar.xz qemu-bf6ce5ec6d6846d7c1fc3899438ec11efc9c8fc8.zip | |
block/nvme: Improve error message when IO queue creation failed
Do not use the same error message for different failures.
Display a different error whether it is the CQ or the SQ.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200821195359.1285345-6-philmd@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/nvme.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/block/nvme.c b/block/nvme.c index 488d4ddb3b..91dba4ec5d 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -648,7 +648,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error **errp) .cdw11 = cpu_to_le32(0x3), }; if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { - error_setg(errp, "Failed to create io queue [%d]", n); + error_setg(errp, "Failed to create CQ io queue [%d]", n); nvme_free_queue_pair(q); return false; } @@ -659,7 +659,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error **errp) .cdw11 = cpu_to_le32(0x1 | (n << 16)), }; if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) { - error_setg(errp, "Failed to create io queue [%d]", n); + error_setg(errp, "Failed to create SQ io queue [%d]", n); nvme_free_queue_pair(q); return false; } |