summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Maydell2014-05-13 17:09:38 +0200
committerPeter Maydell2014-05-13 17:09:38 +0200
commitc94239fe5633fb9816b5bbc61ccc134ce7171b2b (patch)
treee0a675d2ab62cfe5f85d20e94d826f566739abf2
parenthw/intc/allwinner-a10-pic: Add missing 'break' (diff)
downloadqemu-c94239fe5633fb9816b5bbc61ccc134ce7171b2b.tar.gz
qemu-c94239fe5633fb9816b5bbc61ccc134ce7171b2b.tar.xz
qemu-c94239fe5633fb9816b5bbc61ccc134ce7171b2b.zip
hw/net/cadence_gem: Remove dead code
Commit 191946c moved the code to handle padding to minimum length from after the handling of the CRC to before it. This means that the CRC code doesn't need to cope with the possibility that the size is less than 60; remove this dead code. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
-rw-r--r--hw/net/cadence_gem.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index a779658314..47e70381fe 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -717,7 +717,6 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
rxbuf_ptr = (void *)buf;
} else {
unsigned crc_val;
- int crc_offset;
/* The application wants the FCS field, which QEMU does not provide.
* We must try and caclculate one.
@@ -727,12 +726,7 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
memset(rxbuf + size, 0, sizeof(rxbuf) - size);
rxbuf_ptr = rxbuf;
crc_val = cpu_to_le32(crc32(0, rxbuf, MAX(size, 60)));
- if (size < 60) {
- crc_offset = 60;
- } else {
- crc_offset = size;
- }
- memcpy(rxbuf + crc_offset, &crc_val, sizeof(crc_val));
+ memcpy(rxbuf + size, &crc_val, sizeof(crc_val));
bytes_to_copy += 4;
size += 4;