diff options
| author | Jack Un | 2014-08-09 22:34:36 +0200 |
|---|---|---|
| committer | Gerd Hoffmann | 2014-08-29 12:51:43 +0200 |
| commit | cae7f29c47dee0bd0474fa7f1dda28b115a34d33 (patch) | |
| tree | 264544c22497ac75c07f47ca2db6eec5c16f1dab | |
| parent | xhci: fix debug print compiling error (diff) | |
| download | qemu-cae7f29c47dee0bd0474fa7f1dda28b115a34d33.tar.gz qemu-cae7f29c47dee0bd0474fa7f1dda28b115a34d33.tar.xz qemu-cae7f29c47dee0bd0474fa7f1dda28b115a34d33.zip | |
Fix OHCI ISO TD state never being written back.
There appears to be typo in OHCI with isochronous transfers
resulting in isoch. transfer descriptor state never being written back.
The'put_words' function is in a OR statement hence it is never called.
Signed-off-by: Jack Un <jack.un@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | hw/usb/hcd-ohci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 13afdf5919..cacf7b054c 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -619,8 +619,8 @@ static inline int ohci_put_td(OHCIState *ohci, static inline int ohci_put_iso_td(OHCIState *ohci, dma_addr_t addr, struct ohci_iso_td *td) { - return put_dwords(ohci, addr, (uint32_t *)td, 4 || - put_words(ohci, addr + 16, td->offset, 8)); + return put_dwords(ohci, addr, (uint32_t *)td, 4) || + put_words(ohci, addr + 16, td->offset, 8); } static inline int ohci_put_hcca(OHCIState *ohci, |