diff options
| author | Jason Wang | 2013-02-21 04:05:56 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2013-02-27 16:10:47 +0100 |
| commit | ce675a7579fea498397c5d2da3c5367671e9f02a (patch) | |
| tree | d9b1bdbdac18c9f66c0c7d2f986019452f513896 | |
| parent | net: fix unbounded NetQueue (diff) | |
| download | qemu-ce675a7579fea498397c5d2da3c5367671e9f02a.tar.gz qemu-ce675a7579fea498397c5d2da3c5367671e9f02a.tar.xz qemu-ce675a7579fea498397c5d2da3c5367671e9f02a.zip | |
tap: forbid creating multiqueue tap when hub is used
Obviously, hub does not support multiqueue tap. So this patch forbids creating
multiple queue tap when hub is used to prevent the crash when command line such
as "-net tap,queues=2" is used.
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | net/tap.c | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -693,6 +693,13 @@ int net_init_tap(const NetClientOptions *opts, const char *name, queues = tap->has_queues ? tap->queues : 1; vhostfdname = tap->has_vhostfd ? tap->vhostfd : NULL; + /* QEMU vlans does not support multiqueue tap, in this case peer is set. + * For -netdev, peer is always NULL. */ + if (peer && (tap->has_queues || tap->has_fds || tap->has_vhostfds)) { + error_report("Multiqueue tap cannnot be used with QEMU vlans"); + return -1; + } + if (tap->has_fd) { if (tap->has_ifname || tap->has_script || tap->has_downscript || tap->has_vnet_hdr || tap->has_helper || tap->has_queues || |