diff options
| author | Alex Bennée | 2016-09-30 23:30:58 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-10-04 10:00:26 +0200 |
| commit | ce7cf6a973f4b614162b9518954d441fa5e32fc6 (patch) | |
| tree | 92689693586f5738d981c13c4096e879f51d6c87 | |
| parent | qom/object: update class cache atomically (diff) | |
| download | qemu-ce7cf6a973f4b614162b9518954d441fa5e32fc6.tar.gz qemu-ce7cf6a973f4b614162b9518954d441fa5e32fc6.tar.xz qemu-ce7cf6a973f4b614162b9518954d441fa5e32fc6.zip | |
qom/cpu: atomically clear the tb_jmp_cache
The ThreadSanitizer rightly complains that something initialised with a
normal access is later updated and read atomically.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20160930213106.20186-8-alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | qom/cpu.c | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -253,6 +253,7 @@ void cpu_reset(CPUState *cpu) static void cpu_common_reset(CPUState *cpu) { CPUClass *cc = CPU_GET_CLASS(cpu); + int i; if (qemu_loglevel_mask(CPU_LOG_RESET)) { qemu_log("CPU Reset (CPU %d)\n", cpu->cpu_index); @@ -268,7 +269,10 @@ static void cpu_common_reset(CPUState *cpu) cpu->can_do_io = 1; cpu->exception_index = -1; cpu->crash_occurred = false; - memset(cpu->tb_jmp_cache, 0, TB_JMP_CACHE_SIZE * sizeof(void *)); + + for (i = 0; i < TB_JMP_CACHE_SIZE; ++i) { + atomic_set(&cpu->tb_jmp_cache[i], NULL); + } } static bool cpu_common_has_work(CPUState *cs) |