diff options
| author | Richard Henderson | 2019-03-14 03:33:48 +0100 |
|---|---|---|
| committer | Richard Henderson | 2019-05-22 18:38:54 +0200 |
| commit | d049b1f2afddd2d3a7b2ed22c274c66305c0b84b (patch) | |
| tree | 61f74c2bf3412874c784be5ad43754f029952a7d | |
| parent | crypto: Use getrandom for qcrypto_random_bytes (diff) | |
| download | qemu-d049b1f2afddd2d3a7b2ed22c274c66305c0b84b.tar.gz qemu-d049b1f2afddd2d3a7b2ed22c274c66305c0b84b.tar.xz qemu-d049b1f2afddd2d3a7b2ed22c274c66305c0b84b.zip | |
crypto: Change the qcrypto_random_bytes buffer type to void*
Using uint8_t* merely requires useless casts for use with
other types to be filled with randomness.
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | crypto/random-gcrypt.c | 2 | ||||
| -rw-r--r-- | crypto/random-gnutls.c | 2 | ||||
| -rw-r--r-- | crypto/random-platform.c | 4 | ||||
| -rw-r--r-- | include/crypto/random.h | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/crypto/random-gcrypt.c b/crypto/random-gcrypt.c index 9f1c9ee60e..7aea4ac81f 100644 --- a/crypto/random-gcrypt.c +++ b/crypto/random-gcrypt.c @@ -24,7 +24,7 @@ #include <gcrypt.h> -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp G_GNUC_UNUSED) { diff --git a/crypto/random-gnutls.c b/crypto/random-gnutls.c index 445fd6a30b..ed6c9ca12f 100644 --- a/crypto/random-gnutls.c +++ b/crypto/random-gnutls.c @@ -26,7 +26,7 @@ #include <gnutls/gnutls.h> #include <gnutls/crypto.h> -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp) { diff --git a/crypto/random-platform.c b/crypto/random-platform.c index cb3ca1bc09..66624106fe 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c @@ -64,8 +64,8 @@ int qcrypto_random_init(Error **errp) return 0; } -int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, - size_t buflen G_GNUC_UNUSED, +int qcrypto_random_bytes(void *buf, + size_t buflen, Error **errp) { #ifdef _WIN32 diff --git a/include/crypto/random.h b/include/crypto/random.h index 8764ca0562..fde592904e 100644 --- a/include/crypto/random.h +++ b/include/crypto/random.h @@ -34,7 +34,7 @@ * * Returns 0 on success, -1 on error */ -int qcrypto_random_bytes(uint8_t *buf, +int qcrypto_random_bytes(void *buf, size_t buflen, Error **errp); |