diff options
| author | Markus Armbruster | 2019-05-14 20:03:07 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2019-05-22 15:00:04 +0200 |
| commit | d18dc3af478664b1d5e0dd3ace1eabb9d160f244 (patch) | |
| tree | 3359ac6b7aa6caf99f31cd20c62bdaeca15d94b4 | |
| parent | qemu-bridge-helper: Fix misuse of isspace() (diff) | |
| download | qemu-d18dc3af478664b1d5e0dd3ace1eabb9d160f244.tar.gz qemu-d18dc3af478664b1d5e0dd3ace1eabb9d160f244.tar.xz qemu-d18dc3af478664b1d5e0dd3ace1eabb9d160f244.zip | |
tests/vhost-user-bridge: Fix misuse of isdigit()
vubr_set_host() passes char values to isdigit(). Undefined behavior
when the value is negative.
Fix by using qemu_isdigit() instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190514180311.16028-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
[Missing #include "qemu-common.h" fixed]
| -rw-r--r-- | tests/vhost-user-bridge.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 0033b61f2e..5b771de7a3 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -30,6 +30,7 @@ #define _FILE_OFFSET_BITS 64 #include "qemu/osdep.h" +#include "qemu-common.h" #include "qemu/atomic.h" #include "qemu/iov.h" #include "standard-headers/linux/virtio_net.h" @@ -645,7 +646,7 @@ vubr_host_notifier_setup(VubrDev *dev) static void vubr_set_host(struct sockaddr_in *saddr, const char *host) { - if (isdigit(host[0])) { + if (qemu_isdigit(host[0])) { if (!inet_aton(host, &saddr->sin_addr)) { fprintf(stderr, "inet_aton() failed.\n"); exit(1); |