diff options
| author | Libo Zhou | 2019-09-11 15:19:26 +0200 |
|---|---|---|
| committer | Aleksandar Markovic | 2019-09-12 18:25:34 +0200 |
| commit | d1cc1533509012916dceeb7f23accda8a9fee85c (patch) | |
| tree | 659fb25378c53fd15aee4ba891edd26896589a94 | |
| parent | hw/mips/mips_jazz: Remove no-longer-necessary override of do_unassigned_access (diff) | |
| download | qemu-d1cc1533509012916dceeb7f23accda8a9fee85c.tar.gz qemu-d1cc1533509012916dceeb7f23accda8a9fee85c.tar.xz qemu-d1cc1533509012916dceeb7f23accda8a9fee85c.zip | |
target/mips: gdbstub: Revert commit 8e0b373
Multiple reports from users were received regarding failures of
packet 'g' communication with gdb for some MIPS configurations.
It was found out (by bisecting) that the problematic commit is
8e0b373. Revert that commit until a better solution is developed.
Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Message-Id: <1568207966-25202-1-git-send-email-aleksandar.markovic@rt-rk.com>
| -rw-r--r-- | target/mips/gdbstub.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c index ebcc98bdde..bbb2544939 100644 --- a/target/mips/gdbstub.c +++ b/target/mips/gdbstub.c @@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0); default: if (env->CP0_Status & (1 << CP0St_FR)) { - return gdb_get_reg64(mem_buf, + return gdb_get_regl(mem_buf, env->active_fpu.fpr[n - 38].d); } else { return gdb_get_regl(mem_buf, @@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) break; default: if (env->CP0_Status & (1 << CP0St_FR)) { - uint64_t tmp = ldq_p(mem_buf); env->active_fpu.fpr[n - 38].d = tmp; } else { env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp; |