summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPrasad J Pandit2019-04-25 08:35:34 +0200
committerGerd Hoffmann2019-05-07 09:11:27 +0200
commitd52680fc932efb8a2f334cc6993e705ed1e31e99 (patch)
tree178da96cccb789d9fc341bef899dc57438f7ac60
parentMerge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request'... (diff)
downloadqemu-d52680fc932efb8a2f334cc6993e705ed1e31e99.tar.gz
qemu-d52680fc932efb8a2f334cc6993e705ed1e31e99.tar.xz
qemu-d52680fc932efb8a2f334cc6993e705ed1e31e99.zip
qxl: check release info object
When releasing spice resources in release_resource() routine, if release info object 'ext.info' is null, it leads to null pointer dereference. Add check to avoid it. Reported-by: Bugs SysSec <bugs-syssec@rub.de> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Message-id: 20190425063534.32747-1-ppandit@redhat.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r--hw/display/qxl.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index c8ce5781e0..632923add2 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -777,6 +777,9 @@ static void interface_release_resource(QXLInstance *sin,
QXLReleaseRing *ring;
uint64_t *item, id;
+ if (!ext.info) {
+ return;
+ }
if (ext.group_id == MEMSLOT_GROUP_HOST) {
/* host group -> vga mode update request */
QXLCommandExt *cmdext = (void *)(intptr_t)(ext.info->id);