diff options
| author | AlexChen | 2020-11-05 16:03:36 +0100 |
|---|---|---|
| committer | Thomas Huth | 2020-11-09 18:34:21 +0100 |
| commit | dccaea2514007dd526a54038ffcaef5fb9c95c0c (patch) | |
| tree | 606d4bff90b5811e1aa834d570aaf6002b6123ab | |
| parent | qtest: Fix bad printf format specifiers (diff) | |
| download | qemu-dccaea2514007dd526a54038ffcaef5fb9c95c0c.tar.gz qemu-dccaea2514007dd526a54038ffcaef5fb9c95c0c.tar.xz qemu-dccaea2514007dd526a54038ffcaef5fb9c95c0c.zip | |
tests/qtest/tpm: Remove redundant check in the tpm_test_swtpm_test()
The 'addr' would not be NULL after checking 'succ' is valid,
and it has been dereferenced in the previous code(args = g_strdup_printf()).
So the check on 'addr' in the tpm_test_swtpm_test() is redundant. Remove it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-Id: <5FA41448.4040404@huawei.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | tests/qtest/tpm-tests.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/qtest/tpm-tests.c b/tests/qtest/tpm-tests.c index 70c80f8379..0da3a8a4df 100644 --- a/tests/qtest/tpm-tests.c +++ b/tests/qtest/tpm-tests.c @@ -70,10 +70,8 @@ void tpm_test_swtpm_test(const char *src_tpm_path, tx_func *tx, qtest_end(); tpm_util_swtpm_kill(swtpm_pid); - if (addr) { - g_unlink(addr->u.q_unix.path); - qapi_free_SocketAddress(addr); - } + g_unlink(addr->u.q_unix.path); + qapi_free_SocketAddress(addr); } void tpm_test_swtpm_migration_test(const char *src_tpm_path, |