diff options
| author | Alberto Faria | 2022-11-08 15:44:33 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2022-11-10 14:52:36 +0100 |
| commit | e56b0c66310feab14a14dd6a24fd58dae178e059 (patch) | |
| tree | efad2ee4116f97e298fc62db7a7517adb8673e21 | |
| parent | qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description (diff) | |
| download | qemu-e56b0c66310feab14a14dd6a24fd58dae178e059.tar.gz qemu-e56b0c66310feab14a14dd6a24fd58dae178e059.tar.xz qemu-e56b0c66310feab14a14dd6a24fd58dae178e059.zip | |
block/blkio: Set BlockDriver::has_variable_length to false
Setting it to true can cause the device size to be queried from libblkio
in otherwise fast paths, degrading performance. Set it to false and
require users to refresh the device size explicitly instead.
Fixes: 4c8f4fda0504 ("block/blkio: Tolerate device size changes")
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Alberto Faria <afaria@redhat.com>
Message-Id: <20221108144433.1334074-1-afaria@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/blkio.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blkio.c b/block/blkio.c index 620fab28a7..5eae3adfaf 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -993,7 +993,6 @@ static void blkio_refresh_limits(BlockDriverState *bs, Error **errp) { \ .format_name = name, \ .protocol_name = name, \ - .has_variable_length = true, \ .instance_size = sizeof(BDRVBlkioState), \ .bdrv_file_open = blkio_file_open, \ .bdrv_close = blkio_close, \ |