diff options
| author | Richard Henderson | 2022-06-02 03:33:47 +0200 |
|---|---|---|
| committer | Laurent Vivier | 2022-06-02 09:35:02 +0200 |
| commit | eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f (patch) | |
| tree | 9f65ef07d4e9b998b1797d4fa908076603f6fb2e | |
| parent | target/m68k: Switch over exception type in m68k_interrupt_all (diff) | |
| download | qemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.tar.gz qemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.tar.xz qemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.zip | |
target/m68k: Fix coding style in m68k_interrupt_all
Add parenthesis around & vs &&.
Remove assignment to sr in function call argument -- note that
sr is unused after the call, so the assignment was never needed,
only the result of the & expression.
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220602013401.303699-4-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | target/m68k/op_helper.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 2b94a6ec84..0f41c2dce3 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw) break; case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7: - if (is_hw && oldsr & SR_M) { + if (is_hw && (oldsr & SR_M)) { do_stack_frame(env, &sp, 0, oldsr, 0, retaddr); oldsr = sr; env->aregs[7] = sp; - cpu_m68k_set_sr(env, sr &= ~SR_M); + cpu_m68k_set_sr(env, sr & ~SR_M); sp = env->aregs[7]; if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) { sp &= ~1; |