diff options
| author | Peter Maydell | 2021-09-20 10:54:32 +0200 |
|---|---|---|
| committer | Peter Maydell | 2021-09-20 10:54:32 +0200 |
| commit | f015cbb546387e1132a15c29e6afacec4a6d2910 (patch) | |
| tree | aa0719bcec3dec6fab0b3aafd4388449ef54e98a | |
| parent | elf2dmp: Check curl_easy_setopt() return value (diff) | |
| download | qemu-f015cbb546387e1132a15c29e6afacec4a6d2910.tar.gz qemu-f015cbb546387e1132a15c29e6afacec4a6d2910.tar.xz qemu-f015cbb546387e1132a15c29e6afacec4a6d2910.zip | |
elf2dmp: Fail cleanly if PDB file specifies zero block_size
Coverity points out that if the PDB file we're trying to read
has a header specifying a block_size of zero then we will
end up trying to divide by zero in pdb_ds_read_file().
Check for this and fail cleanly instead.
Fixes: Coverity CID 1458869
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20210910170656.366592-3-philmd@redhat.com
Message-Id: <20210901143910.17112-3-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| -rw-r--r-- | contrib/elf2dmp/pdb.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c index b3a6547068..adcfa7e154 100644 --- a/contrib/elf2dmp/pdb.c +++ b/contrib/elf2dmp/pdb.c @@ -215,6 +215,10 @@ out_symbols: static int pdb_reader_ds_init(struct pdb_reader *r, PDB_DS_HEADER *hdr) { + if (hdr->block_size == 0) { + return 1; + } + memset(r->file_used, 0, sizeof(r->file_used)); r->ds.header = hdr; r->ds.toc = pdb_ds_read(hdr, (uint32_t *)((uint8_t *)hdr + |