summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Henderson2022-04-17 20:30:00 +0200
committerRichard Henderson2022-04-20 19:51:11 +0200
commitfb6efecf548fc8ef8cc377f076312b1cf4061cac (patch)
tree3f9c58688837c53036905c0800f80b75a4c322b5
parentutil/log: Remove qemu_log_flush (diff)
downloadqemu-fb6efecf548fc8ef8cc377f076312b1cf4061cac.tar.gz
qemu-fb6efecf548fc8ef8cc377f076312b1cf4061cac.tar.xz
qemu-fb6efecf548fc8ef8cc377f076312b1cf4061cac.zip
util/log: Drop call to setvbuf
Now that the log buffer is flushed after every qemu_log_unlock, which includes every call to qemu_log, we do not need to force line buffering (or unbuffering for windows). Block buffer the entire loggable unit. Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20220417183019.755276-21-richard.henderson@linaro.org>
-rw-r--r--util/log.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/util/log.c b/util/log.c
index cab0642a7f..caa38e707b 100644
--- a/util/log.c
+++ b/util/log.c
@@ -136,12 +136,6 @@ bool qemu_set_log(int log_flags, Error **errp)
logfile->fd = stderr;
}
-#if defined(_WIN32)
- /* Win32 doesn't support line-buffering, so use unbuffered output. */
- setvbuf(logfile->fd, NULL, _IONBF, 0);
-#else
- setvbuf(logfile->fd, NULL, _IOLBF, 0);
-#endif
log_append = 1;
qatomic_rcu_set(&qemu_logfile, logfile);
}