summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Musta2014-06-30 15:13:36 +0200
committerAlexander Graf2014-09-08 12:50:46 +0200
commitfbdc200ac2d0d29e88ee6af9b77810c0f84265a6 (patch)
tree80d19ddd4d86c40a8f2a4d6b4d1652b4d46c1fb1
parentppc: spapr-rtas - implement os-term rtas call (diff)
downloadqemu-fbdc200ac2d0d29e88ee6af9b77810c0f84265a6.tar.gz
qemu-fbdc200ac2d0d29e88ee6af9b77810c0f84265a6.tar.xz
qemu-fbdc200ac2d0d29e88ee6af9b77810c0f84265a6.zip
linux-user: Fix Stack Pointer Bug in PPC setup_rt_frame
The code that sets the stack frame back pointer is incorrect for the setup_rt_frame() code; qemu will abort (SIGSEGV) in some environments. The setup_frame code was fixed in commit beb526b12134a6b6744125deec5a7fe24a8f92e3 but the setup_rt_frame code was not. Make the setup_rt_frame code consistent with the setup_frame code. Signed-off-by: Tom Musta <tommusta@gmail.com> Signed-off-by: Alexander Graf <agraf@suse.de>
-rw-r--r--linux-user/signal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 26929c59de..29529563ea 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -4751,7 +4751,7 @@ static void setup_rt_frame(int sig, struct target_sigaction *ka,
/* Create a stack frame for the caller of the handler. */
newsp = rt_sf_addr - (SIGNAL_FRAMESIZE + 16);
- __put_user(env->gpr[1], (target_ulong *)(uintptr_t) newsp);
+ err |= put_user(env->gpr[1], newsp, target_ulong);
if (err)
goto sigsegv;