summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Blake2018-03-23 21:43:41 +0100
committerEric Blake2018-03-27 17:17:32 +0200
commitfdf235ba15167faa05fedb838562fc06e238f400 (patch)
tree9100841d1534fc37142330773f4e2a94fcd7dce0
parentqmp-test: fix response leak (diff)
downloadqemu-fdf235ba15167faa05fedb838562fc06e238f400.tar.gz
qemu-fdf235ba15167faa05fedb838562fc06e238f400.tar.xz
qemu-fdf235ba15167faa05fedb838562fc06e238f400.zip
tests: Silence false positive warning on generated test name
Running 'make check' on rawhide with gcc 8.0.1 fails: tests/test-visitor-serialization.c: In function 'main': tests/test-visitor-serialization.c:1127:34: error: '/primitives/' directive writing 12 bytes into a region of size between 1 and 128 [-Werror=format-overflow=] The warning is a false positive (we have two buffers of size 128, so yes, if we FULLY used the first buffer, then sprint'ing it into the second will overflow the second). But in practice, our first buffer will not be longer than "/visitor/serialization/String", so sizing it smaller is enough to let gcc see that we don't overflow the second. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20180323204341.1501664-1-eblake@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
-rw-r--r--tests/test-visitor-serialization.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test-visitor-serialization.c b/tests/test-visitor-serialization.c
index 438c18a0d6..d18d90db2c 100644
--- a/tests/test-visitor-serialization.c
+++ b/tests/test-visitor-serialization.c
@@ -1115,7 +1115,7 @@ static const SerializeOps visitors[] = {
static void add_visitor_type(const SerializeOps *ops)
{
- char testname_prefix[128];
+ char testname_prefix[32];
char testname[128];
TestArgs *args;
int i = 0;