diff options
| author | Pavel Borzenkov | 2011-10-18 19:17:35 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2011-10-26 14:36:35 +0200 |
| commit | feba23b14340965b9dad9251ec9a7a47313fbf69 (patch) | |
| tree | 38806b29e669df865755b76ac8a069bf43b01b03 | |
| parent | vmdk: vmdk_read_cid returns garbage if p_name is NULL (diff) | |
| download | qemu-feba23b14340965b9dad9251ec9a7a47313fbf69.tar.gz qemu-feba23b14340965b9dad9251ec9a7a47313fbf69.tar.xz qemu-feba23b14340965b9dad9251ec9a7a47313fbf69.zip | |
qed: don't pass NULL to memcpy
Spotted by Clang Analyzer
[Note this memcpy call has always been safe because the length will be 0
when the pointer is NULL]
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
| -rw-r--r-- | block/qed.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/block/qed.c b/block/qed.c index e87dc4decf..7fab155b1a 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1425,8 +1425,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs, memcpy(buffer, &le_header, sizeof(le_header)); buffer_len = sizeof(le_header); - memcpy(buffer + buffer_len, backing_file, backing_file_len); - buffer_len += backing_file_len; + if (backing_file) { + memcpy(buffer + buffer_len, backing_file, backing_file_len); + buffer_len += backing_file_len; + } /* Write new header */ ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len); |