summaryrefslogtreecommitdiffstats
path: root/CODING_STYLE
diff options
context:
space:
mode:
authorWei Yang2019-03-04 08:16:30 +0100
committerLaurent Vivier2019-05-02 18:12:58 +0200
commit6ac1fca4ef29d8deaea50b0c7a45e0e9e59ff656 (patch)
treeb98b759c9cc471b1482bcd95d94a4d89f75e6e50 /CODING_STYLE
parenthw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf (diff)
downloadqemu-6ac1fca4ef29d8deaea50b0c7a45e0e9e59ff656.tar.gz
qemu-6ac1fca4ef29d8deaea50b0c7a45e0e9e59ff656.tar.xz
qemu-6ac1fca4ef29d8deaea50b0c7a45e0e9e59ff656.zip
CODING_STYLE: specify the indent rule for multiline code
We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Suggested-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20190304071631.27567-2-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'CODING_STYLE')
-rw-r--r--CODING_STYLE39
1 files changed, 39 insertions, 0 deletions
diff --git a/CODING_STYLE b/CODING_STYLE
index ec075dedc4..90321e9c28 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -29,6 +29,45 @@ Spaces of course are superior to tabs because:
Do not leave whitespace dangling off the ends of lines.
+1.1 Multiline Indent
+
+There are several places where indent is necessary:
+
+ - if/else
+ - while/for
+ - function definition & call
+
+When breaking up a long line to fit within line width, we need a proper indent
+for the following lines.
+
+In case of if/else, while/for, align the secondary lines just after the
+opening parenthesis of the first.
+
+For example:
+
+ if (a == 1 &&
+ b == 2) {
+
+ while (a == 1 &&
+ b == 2) {
+
+In case of function, there are several variants:
+
+ * 4 spaces indent from the beginning
+ * align the secondary lines just after the opening parenthesis of the
+ first
+
+For example:
+
+ do_something(x, y,
+ z);
+
+ do_something(x, y,
+ z);
+
+ do_something(x, do_another(y,
+ z));
+
2. Line width
Lines should be 80 characters; try not to make them longer.