diff options
author | Connor Kuehl | 2021-03-05 16:19:28 +0100 |
---|---|---|
committer | Kevin Wolf | 2021-03-08 14:56:55 +0100 |
commit | 785ec4b1b968906ea1d22f753a3b199be946550b (patch) | |
tree | 3a485c16996e771baa773603ab3f37877a1da39e /MAINTAINERS | |
parent | docs: qsd: Explain --export nbd,name=... default (diff) | |
download | qemu-785ec4b1b968906ea1d22f753a3b199be946550b.tar.gz qemu-785ec4b1b968906ea1d22f753a3b199be946550b.tar.xz qemu-785ec4b1b968906ea1d22f753a3b199be946550b.zip |
block: Clarify error messages pertaining to 'node-name'
Some error messages contain ambiguous representations of the 'node-name'
parameter. This can be particularly confusing when exchanging QMP
messages (C = client, S = server):
C: {"execute": "block_resize", "arguments": { "device": "my_file", "size": 26843545600 }}
S: {"error": {"class": "GenericError", "desc": "Cannot find device=my_file nor node_name="}}
^^^^^^^^^
This error message suggests one could send a message with a key called
'node_name':
C: {"execute": "block_resize", "arguments": { "node_name": "my_file", "size": 26843545600 }}
^^^^^^^^^
but using the underscore is actually incorrect, the parameter should be
'node-name':
S: {"error": {"class": "GenericError", "desc": "Parameter 'node_name' is unexpected"}}
This behavior was uncovered in bz1651437, but I ended up going down a
rabbit hole looking for other areas where this miscommunication might
occur and changing those accordingly as well.
Fixes: https://bugzilla.redhat.com/1651437
Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Message-Id: <20210305151929.1947331-2-ckuehl@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions