diff options
author | Markus Armbruster | 2022-03-15 15:41:55 +0100 |
---|---|---|
committer | Markus Armbruster | 2022-03-21 15:44:44 +0100 |
commit | 1366244ab6d0c83bf0f90270e5bb608651a3cc8f (patch) | |
tree | e315609c3297e701b93bff8e7d5fd7bcaf3e94c5 /audio | |
parent | scripts/coccinelle: New use-g_new-etc.cocci (diff) | |
download | qemu-1366244ab6d0c83bf0f90270e5bb608651a3cc8f.tar.gz qemu-1366244ab6d0c83bf0f90270e5bb608651a3cc8f.tar.xz qemu-1366244ab6d0c83bf0f90270e5bb608651a3cc8f.zip |
9pfs: Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
This commit only touches allocations with size arguments of the form
sizeof(T).
Initial patch created mechanically with:
$ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
--macro-file scripts/cocci-macro-file.h FILES...
This uncovers a typing error:
../hw/9pfs/9p.c: In function ‘qid_path_fullmap’:
../hw/9pfs/9p.c:855:13: error: assignment to ‘QpfEntry *’ from incompatible pointer type ‘QppEntry *’ [-Werror=incompatible-pointer-types]
855 | val = g_new0(QppEntry, 1);
| ^
Harmless, because QppEntry is larger than QpfEntry. Manually fixed to
allocate a QpfEntry instead.
Cc: Greg Kurz <groug@kaod.org>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220315144156.1595462-3-armbru@redhat.com>
Diffstat (limited to 'audio')
0 files changed, 0 insertions, 0 deletions