diff options
| author | Volker Rümelin | 2021-01-10 11:02:33 +0100 |
|---|---|---|
| committer | Gerd Hoffmann | 2021-01-15 11:25:22 +0100 |
| commit | cffd2fdf2c121804ac97a43f051a8d8cd71508b4 (patch) | |
| tree | 0bc5a25a96770e78ea787361800475e40f96b67f /audio | |
| parent | paaudio: remove unneeded code (diff) | |
| download | qemu-cffd2fdf2c121804ac97a43f051a8d8cd71508b4.tar.gz qemu-cffd2fdf2c121804ac97a43f051a8d8cd71508b4.tar.xz qemu-cffd2fdf2c121804ac97a43f051a8d8cd71508b4.zip | |
paaudio: comment bugs in functions qpa_init_*
The audio buffer size in audio/paaudio.c is typically larger
than expected. Just comment the bugs in qpa_init_in() and
qpa_init_out() for now. Fixing these bugs may break glitch free
audio playback with fine tuned user audio settings.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-17-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'audio')
| -rw-r--r-- | audio/paaudio.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/audio/paaudio.c b/audio/paaudio.c index 86038f3e13..ff3dd01c96 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -538,6 +538,10 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings *as, } audio_pcm_init_info (&hw->info, &obt_as); + /* + * This is wrong. hw->samples counts in frames. hw->samples will be + * number of channels times larger than expected. + */ hw->samples = audio_buffer_samples( qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); @@ -585,6 +589,10 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) } audio_pcm_init_info (&hw->info, &obt_as); + /* + * This is wrong. hw->samples counts in frames. hw->samples will be + * number of channels times larger than expected. + */ hw->samples = audio_buffer_samples( qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); |