summaryrefslogtreecommitdiffstats
path: root/block.c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé2020-03-18 23:22:35 +0100
committerMax Reitz2020-03-24 11:41:46 +0100
commita15f08dceebce63ee15c91c7d74265d61d882ae5 (patch)
treed5e96d90ae6773d113feb7ed0f6375c8e26ba1ce /block.c
parentblock: Avoid memleak on qcow2 image info failure (diff)
downloadqemu-a15f08dceebce63ee15c91c7d74265d61d882ae5.tar.gz
qemu-a15f08dceebce63ee15c91c7d74265d61d882ae5.tar.xz
qemu-a15f08dceebce63ee15c91c7d74265d61d882ae5.zip
block: Assert BlockDriver::format_name is not NULL
bdrv_do_find_format() calls strcmp() using BlockDriver::format_name as argument, which must not be NULL. Assert this field is not null when we register a block driver in bdrv_register(). Reported-by: Mansour Ahmadi <ManSoSec@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200318222235.23856-1-philmd@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r--block.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/block.c b/block.c
index a2542c977b..6b984dc883 100644
--- a/block.c
+++ b/block.c
@@ -363,6 +363,7 @@ char *bdrv_get_full_backing_filename(BlockDriverState *bs, Error **errp)
void bdrv_register(BlockDriver *bdrv)
{
+ assert(bdrv->format_name);
QLIST_INSERT_HEAD(&bdrv_drivers, bdrv, list);
}