summaryrefslogtreecommitdiffstats
path: root/block.c
diff options
context:
space:
mode:
authorKevin Wolf2010-04-01 22:48:44 +0200
committerAurelien Jarno2010-04-10 00:14:23 +0200
commitcb6d3ca07b8f62b47ef30c6a92caa3e8bd71248b (patch)
tree40a48a4634cc5ac2a32742be67e6c96bd65eab87 /block.c
parentImplement virtio reset (diff)
downloadqemu-cb6d3ca07b8f62b47ef30c6a92caa3e8bd71248b.tar.gz
qemu-cb6d3ca07b8f62b47ef30c6a92caa3e8bd71248b.tar.xz
qemu-cb6d3ca07b8f62b47ef30c6a92caa3e8bd71248b.zip
block: Fix multiwrite error handling
When two requests of the same multiwrite batch fail, the callback of all requests in that batch were called twice. This could have any kind of nasty effects, in my case it lead to use after free and eventually a segfault. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Diffstat (limited to 'block.c')
-rw-r--r--block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block.c b/block.c
index e891544dd1..06ed08ad88 100644
--- a/block.c
+++ b/block.c
@@ -1740,7 +1740,7 @@ static void multiwrite_cb(void *opaque, int ret)
{
MultiwriteCB *mcb = opaque;
- if (ret < 0) {
+ if (ret < 0 && !mcb->error) {
mcb->error = ret;
multiwrite_user_cb(mcb);
}