diff options
| author | Markus Armbruster | 2019-04-17 21:06:28 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2019-04-17 21:21:49 +0200 |
| commit | 6b3048cee0e0eccd27b62954ecc57c4a1bceb976 (patch) | |
| tree | 17dcc0ef5b02a1dffe52709bb891400fd05570a4 /block/trace-events | |
| parent | qemu-img: Use error_vreport() in error_exit() (diff) | |
| download | qemu-6b3048cee0e0eccd27b62954ecc57c4a1bceb976.tar.gz qemu-6b3048cee0e0eccd27b62954ecc57c4a1bceb976.tar.xz qemu-6b3048cee0e0eccd27b62954ecc57c4a1bceb976.zip | |
block/ssh: Do not report read/write/flush errors to the user
Callbacks ssh_co_readv(), ssh_co_writev(), ssh_co_flush() report
errors to the user with error_printf(). They shouldn't, it's their
caller's job. Replace by a suitable trace point. While there, drop
the unreachable !s->sftp case.
Perhaps we should convert this part of the block driver interface to
Error, so block drivers can pass more detail to their callers. Not
today.
Cc: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190417190641.26814-3-armbru@redhat.com>
Diffstat (limited to 'block/trace-events')
| -rw-r--r-- | block/trace-events | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/block/trace-events b/block/trace-events index 7335a42540..79ccd8d824 100644 --- a/block/trace-events +++ b/block/trace-events @@ -208,3 +208,6 @@ sheepdog_co_rw_vector_new(uint64_t oid) "new oid 0x%" PRIx64 sheepdog_snapshot_create_info(const char *sn_name, const char *id, const char *name, int64_t size, int is_snapshot) "sn_info: name %s id_str %s s: name %s vm_state_size %" PRId64 " " "is_snapshot %d" sheepdog_snapshot_create(const char *sn_name, const char *id) "%s %s" sheepdog_snapshot_create_inode(const char *name, uint32_t snap, uint32_t vdi) "s->inode: name %s snap_id 0x%" PRIx32 " vdi 0x%" PRIx32 + +# ssh.c +sftp_error(const char *op, const char *ssh_err, int ssh_err_code, unsigned long sftp_err_code) "%s failed: %s (libssh2 error code: %d, sftp error code: %lu)" |