diff options
| author | Kevin Wolf | 2016-04-19 17:27:24 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2016-05-25 19:04:21 +0200 |
| commit | 0c3169dffa68fcdc71ad42e9a60faa4778de0397 (patch) | |
| tree | 6d92e0809cc9efc94c6fd4b3fe015b7026a4656a /block | |
| parent | block: Cancel jobs first in bdrv_close_all() (diff) | |
| download | qemu-0c3169dffa68fcdc71ad42e9a60faa4778de0397.tar.gz qemu-0c3169dffa68fcdc71ad42e9a60faa4778de0397.tar.xz qemu-0c3169dffa68fcdc71ad42e9a60faa4778de0397.zip | |
block: Default to enabled write cache in blk_new()
The existing users of the function are:
1. blk_new_open(), which already enabled the write cache
2. Some test cases that don't care about the setting
3. blockdev_init() for empty drives, where the cache mode is overridden
with the value from the options when a medium is inserted
Therefore, this patch doesn't change the current behaviour. It will be
convenient, however, for additional users of blk_new() (like block
jobs) if the most sensible WCE setting is the default.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/block-backend.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block/block-backend.c b/block/block-backend.c index f9da1d171c..c8b13f1995 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -125,6 +125,8 @@ BlockBackend *blk_new(void) blk = g_new0(BlockBackend, 1); blk->refcnt = 1; + blk_set_enable_write_cache(blk, true); + qemu_co_queue_init(&blk->public.throttled_reqs[0]); qemu_co_queue_init(&blk->public.throttled_reqs[1]); @@ -160,7 +162,6 @@ BlockBackend *blk_new_open(const char *filename, const char *reference, return NULL; } - blk_set_enable_write_cache(blk, true); blk->root = bdrv_root_attach_child(bs, "root", &child_root, blk); return blk; |