diff options
| author | Alberto Garcia | 2016-09-15 16:53:00 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2016-09-23 13:36:10 +0200 |
| commit | 14499ea5413be45bbb3934dd6fd8fa27c54c1dd4 (patch) | |
| tree | 1a9eced273e3553c099021ac57a6d41053cf2eba /block | |
| parent | block: Remove bdrv_is_snapshot (diff) | |
| download | qemu-14499ea5413be45bbb3934dd6fd8fa27c54c1dd4.tar.gz qemu-14499ea5413be45bbb3934dd6fd8fa27c54c1dd4.tar.xz qemu-14499ea5413be45bbb3934dd6fd8fa27c54c1dd4.zip | |
block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags
If an image is opened with snapshot=on, its flags are modified by
bdrv_backing_options() and then bs->open_flags is updated accordingly.
This last step is unnecessary if we calculate the new flags before
setting bs->open_flags.
Soon we'll introduce the "read-only" option, and then we'll need to
be able to modify its value in the QDict when snapshot=on. This is
more cumbersome if bs->options is already set. This patch simplifies
that. Other than that, there are no semantic changes. Although it
might seem that bs->options can have a different value now because
it is stored after calling bdrv_backing_options(), this call doesn't
actually modify them in this scenario.
The code that sets BDRV_O_ALLOW_RDWR is also moved for the same
reason.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions